]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
appDisplay: Clear animateLater callbacks when unmapping
authorJonas Ådahl <jadahl@gmail.com>
Tue, 31 Mar 2020 17:00:58 +0000 (19:00 +0200)
committerJonas Ådahl <jadahl@gmail.com>
Tue, 31 Mar 2020 17:05:15 +0000 (19:05 +0200)
In some situations we could end up not with lingering 'view-loaded'
handler. This could result in delayed spring animate-in being initiated,
e.g. after a minute after the activities overview was already closed.

Fix this by removing any lingering signal or later handlers when
unmapping.

Fixes: 5c33fe4a0a4eb4ed
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1155

js/ui/appDisplay.js

index 4ba4ed67cb91975d66f6a7f4697b968c27864ddd..e07769caa71f806c33a2cab82b694f5a55c5b39a 100644 (file)
@@ -291,6 +291,11 @@ var BaseAppView = GObject.registerClass({
         }
     }
 
+    vfunc_unmap() {
+        this._clearAnimateLater();
+        super.vfunc_unmap();
+    }
+
     animateSwitch(animationDirection) {
         this.remove_all_transitions();
         this._grid.remove_all_transitions();